search

metafizzy / outlayer

:construction_worker: the brains & guts of a layout library
163 stars 63 forks source link

Added a fix for an intermittent IE issue #4

Closed ghost closed 9 years ago

ghost commented 10 years ago

Internet Explorer 10 (on Windows 7 inside a VM) would sometimes report that this.layout.size was null or undefined when running layoutPosition() for the first item in my Masonry layout. I could never discern any pattern as to when IE decided to issue the error and when it didn't, leads me to think there may be a race condition somewhere in Outlayer. Being more intimately familiar with Outlayer's inner workings, you probably have a better idea of what's going on than I do. At any rate, this fix appears to have corrected the issue for me, and I wanted to share it.

desandro commented 10 years ago

hey, thanks for the issue reporting. Before I merge this in, I'd like to wait on it for a bit, in case anyone else is having the same issue so we can get to the bottom of what's really happening.

I'll try to take a deeper look into this.

desandro commented 9 years ago

Closing as this issue didn't get much attention. :ghost: