search

metafizzy / outlayer

:construction_worker: the brains & guts of a layout library
163 stars 63 forks source link

fix bug with scrolling when there is infinity scroll #50

Closed psixdev closed 8 years ago

psixdev commented 8 years ago

When I used Masonry library i had a problem: on page with infinity scroll the slider stuck to bottom of page if I swipe it by mouse. It code fix problem.

desandro commented 8 years ago

Thank you for this contribution. This looks like an edge case. position: absolute is set initially, so it doesn't need to keep being set for every layout. I can see how this fix resolved your situation, but I don't think it needs to go into Outlayer.

I very much appreciate your contribution here, but I'm sorry I'll have to pass on it. I hope this doesn't discourage from proposing more PRs and hope you continue staying involved in open source

psixdev commented 8 years ago

You are mistaken in the arguments. position: absolute and so is already set for each layout, as in my decision, but upon initialization. However, the current library code breaks the browser behavior. I am puzzled by this cause and your unwillingness to solve the problem.