search

metafizzy / zdog

Flat, round, designer-friendly pseudo-3D engine for canvas & SVG
https://zzz.dog
10.36k stars 393 forks source link

Migrate codebase to ES8/TypeScript? #100

Open ZeevKatz opened 4 years ago

ZeevKatz commented 4 years ago

What do you think guys about migrating Zdog codebase to ES8/TypeScript? 💪 It will improve coding time and let new people that want to contribute this project an easier start point.

demensky commented 4 years ago

I think this is a good idea. But migrating this codebase to typescript can be more difficult than reimplementing the library. If you want to use it with typescript you can install the definitions.

ZeevKatz commented 4 years ago

@demensky My suggestion was not for using Zdog with TypeScript but to improve the codebase and encourage contribution. I can take the challenge but we’ll need to do it step-by-step and keep a long live branch until we finish, what do you think?

demensky commented 4 years ago

Let's try.

ZeevKatz commented 4 years ago

@demensky Can you please open a new branch for this? (migrate-to-typescript)

demensky commented 4 years ago

@desandro

demensky commented 4 years ago

I do not have permission for this repository. I was just creating definitions.

ZeevKatz commented 4 years ago

@desandro ?

desandro commented 3 years ago
  1. I'm open to migrating to ES8. This will likely happen in the next major version upgrade
  2. Yes, I should add TypeScript definition at least. But I prefer keeping the source code in vanilla JavaScript that can be run right in the browser without compilation.

I've been taking a break from Metafizzy development. I may evaluate this in 2021