search

metaflowltd / flutter_health_fit

A flutter plugin for using Apple HealthKit and Google Fit.
Other
86 stars 31 forks source link

Introduce specific authorization and add blood glucose and blood pressure for Android #64

Open felixgabler opened 2 years ago

felixgabler commented 2 years ago

Hi! Thanks a lot for this plugin. I use it in one of my projects. However, there were a few things I needed to build which I would like to share back with you if you are interested:

  1. It is now possible to select which permissions should be requested (e.g. just request Workouts). This way, usING the plugin for one vital does not confuse the user because it is requesting everything. I would like to refactor this even more to eventually deprecate the other isXYAuthorized calls.
  2. I changed the blood glucose logic to return a list (which I think would also be useful for weight) and made it work on both platforms (not just on iOS as before)
  3. I also added blood pressure functionality to both plugins

This is just a draft because I realize that it needs to be cleaned up and brought back closer to your coding style. However, I think it definitely provides value so I'd like to start discussing what and how to bring parts of this back into your repository. Thank you!

ronshoshani commented 2 years ago

Hi Felix, Thanks for the PR, it's content looks great! We'd love to work with you on merging it into main 🎉 Let us check who is available for that and get back to you soon :)

felixgabler commented 2 years ago

Hey, I just brought the code closer to your coding styles (could still have to do some of that for iOS if you want). I hope this can help your review :) Best wishes!

felixgabler commented 2 years ago

Hi! Did you have time to look at my latest changes by any chance?