metagenlab / zAMP

zAMP is a bioinformatic pipeline designed for convenient, reproducible and scalable amplicon-based metagenomics
https://zamp.readthedocs.io/en/latest/
MIT License
7 stars 4 forks source link

Update make_input_lists.py #34

Closed Sedreh closed 3 years ago

Sedreh commented 3 years ago

Hi! here in the new version, we will check if the column names (key values) in the config file are present in the local_samples dataframe. If not, then user should see an error for the incorrect input for config files (it will see if variables are both in config and metadata)!! About SRA data, you already have value-error defined there for columns and problems in SRA file and it is also hard-coded values! the only thing that was missing in the pipeline was checking the comparison of config file and local samples column! For path check, I just add an additional error explanation and I think we do not need anything else! as you said the pipeline is checking!

Ok, I came up with these ideas and waiting to hear your opinion.