search

metagov / daostar

DAOstar (or DAO*) is a set of technical standards and tools for DAOs and DAO tooling
https://daostar.org/
MIT License
57 stars 25 forks source link

[Bug] Contract Address for a new registration is being saved incorrectly #130

Closed Rashmi-278 closed 1 year ago

Rashmi-278 commented 1 year ago

Registration contract addresses for Lyra - Demo and ENS DAO were lyra.eth and ens.eth but my wallet address ( I registered them ) was saved as contract address.

image

amanwithwings commented 1 year ago

@Rashmi-278 , perhaps you can also recheck this as a part of this issue:

When I try to generate a daoURI using the snapshot integration, it doesn't include the manager address or a contracts registry URI. Are these being stored anywhere given that the form is accepting them?

Rashmi-278 commented 1 year ago

Hey Aman, I checked the reason for this, we don't have those fields included in the DAO URI Validation schema in our API image

Rashmi-278 commented 1 year ago

@Rashmi-278 , perhaps you can also recheck this as a part of this issue:

When I try to generate a daoURI using the snapshot integration, it doesn't include the manager address or a contracts registry URI. Are these being stored anywhere given that the form is accepting them?

This is a new issue, https://github.com/metagov/daostar/issues/134

thelastjosh commented 1 year ago

First field in registration interface should be hidden because it's not actually used to populate the explorer / daoURI; the contract address is the actual contract address that calls summonRegistration.

However, a contract address is still sometimes useful for populating other endpoints, e.g. for Snapshot. This requirement / change in the interface should get rolled into the new consolidated spec.

eleventh19 commented 1 year ago

Have listed all three bugs in a consolidated spec, meeting getting scheduled for the week of Sept 18 once Rashmi and Josh are back from conference travel

thelastjosh commented 1 year ago

Re: putting ens.eth or lyra.eth into the "contract address" field.

This is not exactly a bug, because what the contract address field is really doing is for SPECIFIC REFERENCE IMPLEMENTATIONS, such as Safe, or Snapshot, we use that contract address / ENS name to pre-populate daoURI. So the contract address they enter at the top IS NOT the contract address that shows up after actual registration.

However, this interface IS confusing. We should hide the actual contract address and only show it when certain frameworks are selected.

thelastjosh commented 1 year ago

Rashmi will add a PR to hide it and close it.

Rashmi-278 commented 1 year ago

PR is ready to be merged https://github.com/metagov/daostar/pull/154

Rashmi-278 commented 1 year ago

PR merged, closing this issue