search

metagov / daostar

DAOstar (or DAO*) is a set of technical standards and tools for DAOs and DAO tooling
https://daostar.org/
MIT License
56 stars 24 forks source link

Integrate Snapshot's daoURI with the attestation framework #205

Closed Rashmi-278 closed 3 months ago

Rashmi-278 commented 9 months ago

Display the DAO URI of snapshot spaces, published by snapshot https://hub.snapshot.org/api/eip4824/ on our frontend with disclaimer that the data provided is by Snapshot and NOT by DAO themselves

crazyyuan commented 8 months ago

It seems that the 'membersURI' from the Snapshot eip4824 API just contains space members, which are not voters. This is not what we want.

thelastjosh commented 8 months ago

What we need to do here next is clearly describe what it means to publish daoURI data through an attestation, i.e. since Snapshot will be publishing daoURI data about DAOs through an attestation. This issue is already being addressed in part through #99 and #100 for Optimism, i.e. because the Optimism Foundation needs to publish daoURI data about the Optimism Collective through an attestation.

Rashmi-278 commented 8 months ago

Created a PR on Snapshot to include voters in their membersURI https://github.com/snapshot-labs/snapshot-hub/pull/812

Conveyed this to their team, waiting for their review and response on this

Rashmi-278 commented 8 months ago

Fabien's review,

In some space there can be millions of voters, I think we need to put a limit on the query otherwise it will take too long to resolve or load for an integrator

Based on this, I've added limit, pagination, and uniqueness checks for members. I've pushed my changes fo further review.

Rashmi-278 commented 6 months ago

Pushed changes, https://github.com/snapshot-labs/snapshot-hub/pull/812

thelastjosh commented 4 months ago

Just taking a long time, ball is still in their court to review Rashmi's PR.

thelastjosh commented 3 months ago

This was combined with #239 , will close for now.