Open wkyu2kg opened 2 years ago
Hi, thanks for the plugin contribution!
As you are working on this, I had a few questions:
How does this code relate to the Metagraph plugin in the katanagraph source code?: https://github.com/KatanaGraph/katana/tree/master/metagraph-plugin
Does this plugin need to be inside the Metagraph core package, or could we package it into a separate repository? The main advantage would be easier tracking of plugin dependencies (like which KatanaGraph versions are supported) as well as the ability to release plugin updates independent of the metagraph core itself.
Thanks for your response to the draft PR. It is still WIP.
* How does this code relate to the Metagraph plugin in the katanagraph source code?: https://github.com/KatanaGraph/katana/tree/master/metagraph-plugin
They are identical. I am repackaging this, hoping to get katanagraph plugin merged to the metagraph core so that it can be reachable to all metagraph users.
Any assistance would be appreciated!
First, I'm excited for other libraries to add plugins for metagraph! Without that, metagraph won't succeed as a project.
Second, I don't think this should live in the metagraph repo directly. We could certainly add it as a new project under the "metagraph-dev" org. The benefits are:
As for making it easily findable by metagraph users, we have a place in the docs where we list community plugins. We should definitely add the Katanagraph plugin to that list. Also, we should look at other ways to make plugin discovery easier. I'm open to ideas.
The one area we should look at including in metagraph core is any new abstract types or abstract algorithms that we expect to be used across plugins. Bringing those into the base will likely make things easier by avoiding plugin dependency issues.
Thanks for the suggestions. This draft PR did help us to find ways to improve our plugin implementation, which still needs some work. We will discuss your recommendation internally and seek your help when ready.
A draft PR for review.