search

metagraph-dev / mlir-graphblas

MLIR tools and dialect for GraphBLAS
https://mlir-graphblas.readthedocs.io/en/latest/
Apache License 2.0
18 stars 6 forks source link

Reformat C++ to match MLIR style #123

Closed seibert closed 3 years ago

seibert commented 3 years ago

As per this comment: https://github.com/metagraph-dev/mlir-graphblas/pull/121#discussion_r694568857

We can use clang-format to format our C++ in the style used by MLIR. We should do this once to bring everything up to spec, and then verify formatting in CI, just as we do with black for Python.

clang-format is in the clang-tools conda package.

chelini commented 3 years ago

@seibert do you want me to do that? I can reformat and add a CI.

seibert commented 3 years ago

We can take care of it, but thanks for the offer! I need to time it between some in-flight PRs since it will definitely create some merge conflicts.

seibert commented 3 years ago

OK, I think we've now finished this out. The repo has been updated to use the MLIR style in clang-format (#126) and we have CI automation now to verify correct formatting of PRs (#134). Instructions for how to reformat code locally are in the README.