Closed jim22k closed 3 years ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
mlir_graphblas/ops.py | 10 | 16 | 62.5% | ||
<!-- | Total: | 16 | 22 | 72.73% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
mlir_graphblas/src/build.py | 2 | 89.19% | ||
<!-- | Total: | 2 | --> |
Totals | |
---|---|
Change from base Build 1399803456: | 0.1% |
Covered Lines: | 3425 |
Relevant Lines: | 4136 |
NOTE: Major overhaul of
graphblas.select
Passing multiple selectors is no longer allowed This greatly simplifies the implementation as we don't need to line up thunks with selectors.
New selector: "probability"
Also Note: The test for this functionality is in
test_select_probability.mlir
and uses the new functional test goodness, allowing us to actually run a test that exercises the C++ random functions. We should look to replace all thelower_xxx.mlir
tests with functional tests in the future.