https://github.com/metagraph-dev/mlir-graphblas/pull/243 adds a bunch of functionality to the IR builder w.r.t. scf.while. It'd be nice if we had more tests. I think simply ensuring that we have close to 100% test coverage in mlir_builder.py would be sufficient. Mostly, testing the excecptions raised would be helpful.
https://github.com/metagraph-dev/mlir-graphblas/pull/243 adds a bunch of functionality to the IR builder w.r.t.
scf.while
. It'd be nice if we had more tests. I think simply ensuring that we have close to 100% test coverage inmlir_builder.py
would be sufficient. Mostly, testing the excecptions raised would be helpful.