metagraph-dev / mlir-graphblas

MLIR tools and dialect for GraphBLAS
https://mlir-graphblas.readthedocs.io/en/latest/
Apache License 2.0
18 stars 6 forks source link

Move structuralize pass to separate file #276

Closed jim22k closed 2 years ago

jim22k commented 2 years ago

Separate structuralize pass logic to handle two cases:

  1. Rewrite as generic version
  2. Handle very simple custom versions

Other custom versions will be left unchanged and will need to be handled by another lowering pass which only looks for those specific custom versions.

For example, ReduceToVector in the structuralize pass doesn't handle custom aggregators (count, argmin, first, etc). All it does is convert non-custom aggregators into ReduceToVectorGeneric. The normal lowering pass will then handle the generic version and separately the custom version.

All DWIM checks are now handled exclusively by the structuralize pass.

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 1948008025


Totals Coverage Status
Change from base Build 1947565749: 0.0%
Covered Lines: 4563
Relevant Lines: 5314

💛 - Coveralls