search

metajack / libstrophe

The libstrophe repository has moved to https://github.com/strophe/libstrophe
http://strophe.im/libstrophe
Other
135 stars 49 forks source link

Option to disable TLS #20

Closed boothj5 closed 12 years ago

boothj5 commented 12 years ago

I've had a problem with a certain server advertising that it supports TLS by returning the TLS feature, but then doesn't respond to the handshake.

Unfortunately I can't find out much about the server.

I originally tried adding a timeout on the handshake, but the coding got pretty low level inside the tls_start function and a much simpler solution seemed to add a TLS disable flag on the connection object. This works with my jabber client that now has the option to call xmpp_conn_disable_tls.

It'd be great if you could put this change in so I can carry on working with your repo rather than my fork. If you have any comments/suggestions of a better way let me know.

Thanks,

James.

metajack commented 12 years ago

This patch looks good, aside from the spacing issue. If you'll fix that I'll merge this in.

boothj5 commented 12 years ago

Great thanks, I've fixed the spacing.

metajack commented 12 years ago

Thanks for this!