Closed Mingism closed 11 years ago
Generally namespaces go in the plugins not in the core. There's even a special plugin call to handle this. Is there some reason this should go in core?
Ah, I did not know that. What is the plugin that should handle the namespaces from other plugins?
It should go in the plugin for xep-0184 if such a plugin exists. Otherwise you should just have it as a constant in your own application.
jack.
On Thu, Apr 11, 2013 at 12:43 AM, kmtsar notifications@github.com wrote:
Ah, I did not know that. What is the plugin that should handle the namespaces from other plugins?
From: Jack Moffitt notifications@github.com Reply-To: metajack/strophejs
<reply+i-13017533-f8419a6c0c4e692bcf0f2210483e6f721299adc9-1254575@reply.git hub.com> Date: Thursday, April 11, 2013 8:40 AM To: metajack/strophejs strophejs@noreply.github.com Cc: Tsar kay@mingism.com Subject: Re: [strophejs] Added namespace for receipts plugin (XEP 184) to the core file (#108)
Generally namespaces go in the plugins not in the core. There's even a special plugin call to handle this. Is there some reason this should go in core?
‹ Reply to this email directly or view it on GitHub https://github.com/metajack/strophejs/pull/108#issuecomment-16219043 .
— Reply to this email directly or view it on GitHubhttps://github.com/metajack/strophejs/pull/108#issuecomment-16219134 .
Added namespace for receipts plugin (XEP 184) to the core file, so if you would use the plugin it would fine the correct namespace