metakgp / Zoom

[Deprecated- Use Naarad instead] Delivering Facebook posts and tweets of MetaKGP realm to FlashPoint
GNU Lesser General Public License v3.0
0 stars 2 forks source link

replace file by environment variables #9 #10

Closed themousepotato closed 6 years ago

themousepotato commented 6 years ago

ce35c12 and 79ae3b8 also changed.

ghostwriternr commented 6 years ago

The changes look good to me, but it'd be nice if someone could test it as well.

icyflame commented 6 years ago

This looks fine. But aren't there more variables? I don't think this is the only one that needs to be put in the env.

themousepotato commented 6 years ago

@icyflame three files changed. i.e ce35c12 and 79ae3b8 also.

icyflame commented 6 years ago

Those changes are not visible in this PR. You have to make the commits on a branch and then open a pull request. Have a look at this guide and check your pull request before creating it.

themousepotato commented 6 years ago

@ghostwriternr I merged those branches and deleted the old ones. But, merge conflicts are occurring. Help, please!

themousepotato commented 6 years ago

@icyflame Resolved merge conflicts. Ready to merge.