Closed proffapt closed 3 months ago
@proffapt have fixed the workflow and the pgpass config that was needed, but in retrospect I feel this is a very bad idea to have the secret exposed in the image as the image is public and hence the secret. Since this is a build-time env variable, I see two ways keeping this a secret.
Yes, I too thought about it if that thing is going to be public with those build args. I would first like to understand why is there a need of such build args. I believe things are done in complicated way which could have rather been simplified. Let's hop on a call with @shikharish and understand the architecture and see whether the core concept can be updated instead of us trying to do ninja techniques on docker secrets.
fixes #5