metakgp / dob

Database of Babel contains every possible bit of information required by any MetaKGP project
GNU General Public License v3.0
0 stars 1 forks source link

Fixed dob backup deploy #6

Closed proffapt closed 3 months ago

proffapt commented 3 months ago

fixes #5

rajivharlalka commented 3 months ago

@proffapt have fixed the workflow and the pgpass config that was needed, but in retrospect I feel this is a very bad idea to have the secret exposed in the image as the image is public and hence the secret. Since this is a build-time env variable, I see two ways keeping this a secret.

  1. use docker secrets ( I have little knowledge and 0 will-power to understand how to configure it with this github action)
  2. build the image locally on the server (either manually or using an updated github action)
proffapt commented 3 months ago

Yes, I too thought about it if that thing is going to be public with those build args. I would first like to understand why is there a need of such build args. I believe things are done in complicated way which could have rather been simplified. Let's hop on a call with @shikharish and understand the architecture and see whether the core concept can be updated instead of us trying to do ninja techniques on docker secrets.