search

metakgp / mcmp

My Choice My Prof [PRESENT IN IITKGP WEBSITE]
http://metakgp.github.io/mcmp/
MIT License
10 stars 6 forks source link

Add professor department while searching #14

Closed kaustubhhiware closed 6 years ago

kaustubhhiware commented 6 years ago

A friend of mine suggested we also show the department of the professor when displaying search results.

This is helpful if a student wants to work within their department only.

Current search result: Sourangshu Bhattacharya | Machine Learning

Suggested change: Sourangshu Bhattacharya | CS | Machine Learning

I can take this up if the need for this is acknowledged by other folks.

athityakumar commented 6 years ago

Makes sense, given that MCMP is usually used to for deciding on BTP/MTP. Also, would some kind of filter (multi-select dropdown) for department be a useful feature?

For example, if someone searches specifically for CS - search results like CS Kumar | ME | Robotics would still appear. This could be handled better by a filter button. But again, these may not be highly occurring results - so, we can skip the filter feature if it's too much work for little enhancement in result.

icyflame commented 6 years ago

The current JSON file doesn't have this data. We will have the scrape the data again with this data. Not sure what script was originally used to scrape this data. Definitely a good idea.

icyflame commented 6 years ago

Okay, found all the required details here. Figuring out how this works. Will create a patch if it's not too involved.

athityakumar commented 6 years ago

Fixed by #16 - not sure why this issue hasn't been closed automatically upon merging #16 🤔