metakgp / metakgp-wiki

Dockerized source for the metakgp wiki.
https://wiki.metakgp.org
GNU General Public License v3.0
23 stars 20 forks source link

Put peqp in a separate volume called "static" #27

Closed icyflame closed 6 years ago

icyflame commented 6 years ago

I hope this is what you meant in your comment in #6 . The changes were pretty easy to make once I got the hang of it. :smile:

icyflame commented 6 years ago

Rebased to latest master.

Remaining:

icyflame commented 6 years ago

image

@amrav Localhost still works. I just setup a new server and tried it and it works. I have rebased to latest master and used this particular build to set this up. Please review and approve! :slightly_smiling_face:

icyflame commented 6 years ago

Hey @amrav, I have solved the issues now. Can you please review and merge? I think all the requirements have been met.

amrav commented 6 years ago

Lgtm if it works, but do you understand why nginx serves the correct domain for localhost? Why isn't it defaulting to static.metakgp.org, for instance?

icyflame commented 6 years ago

@amrav Okay, the mechanism was easy to understand. It's well documented here

In particular:

image

A verbose log of the request:

image

So, the Host: localhost doesn't match anything configured and it just routes the request to the default_server which we have configured to be the wiki server.

I hope that clears it up. This was a good thing to find out! :smile: Okay to merge this patch now?

amrav commented 6 years ago

Sounds good, thanks for clarifying!

On Tue, 14 Nov 2017 at 08:08, Siddharth Kannan notifications@github.com wrote:

@amrav https://github.com/amrav Okay, the mechanism was easy to understand. It's well documented here https://nginx.org/en/docs/http/request_processing.html

In particular:

[image: image] https://user-images.githubusercontent.com/3668034/32769172-c9f135d0-c940-11e7-9f53-b2544764cf93.png

A verbose log of the request:

[image: image] https://user-images.githubusercontent.com/3668034/32769184-d8cd06f6-c940-11e7-9e15-9acb358769c8.png

So, the Host: localhost doesn't match anything configured and it just routes the request to the default_server which we have configured to be the wiki server.

I hope that clears it up. This was a good thing to find out! 😄 Okay to merge this patch now?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/metakgp/metakgp-wiki/pull/27#issuecomment-344177167, or mute the thread https://github.com/notifications/unsubscribe-auth/ABIZ_7ts5HjS8vnZfVr311KSVFobCV7Gks5s2UqMgaJpZM4QJk4b .