search

metakgp / metakgp-wiki

Dockerized source for the metakgp wiki.
https://wiki.metakgp.org
GNU General Public License v3.0
23 stars 20 forks source link

add contribution instructions #50

Closed thealphadollar closed 5 years ago

thealphadollar commented 5 years ago

Added instructions for contributions to help beginners.

The instructions are generic and aimed more at improving methods of creation of PRs, Issues and are less about code resolution.

thealphadollar commented 5 years ago

@icyflame Please check, I've resolved the points put up by you.

thealphadollar commented 5 years ago

@icyflame ping.

icyflame commented 5 years ago

@thealphadollar you seem to have resolved a conversation without making the requested change (in which case, you can resolve) or adding a comment explaining your thinking (in which case you shouldn't resolve and wait for the original author to agree with you and resolve later) 🙂

thealphadollar commented 5 years ago

@thealphadollar you seem to have resolved a conversation without making the requested change (in which case, you can resolve) or adding a comment explaining your thinking (in which case you shouldn't resolve and wait for the original author to agree with you and resolve later)

My apologies, I failed to notice that it wasn't resolved and closed it.

hargup commented 5 years ago

@thealphadollar any update here? I guess the longer you wait to merge the more chances that it will never get merged. Better merge something good enough and fix it later.

thealphadollar commented 5 years ago

@hargup I think I implemented the changes requested by @icyflame. We can move forward with merging this PR.

thealphadollar commented 5 years ago

@icyflame Please review.

icyflame commented 5 years ago

@thealphadollar https://github.com/metakgp/metakgp-wiki/pull/50#issuecomment-454282035

icyflame commented 5 years ago

@hargup I think I implemented the changes requested by @icyflame. We can move forward with merging this PR.

No, the Creating issues section doesn't make any sense in the current form.

thealphadollar commented 5 years ago

@icyflame Please check now. Thanks for the guidance :smile: