search

metakgp / metakgp-wiki

Dockerized source for the metakgp wiki.
https://wiki.metakgp.org
GNU General Public License v3.0
23 stars 20 forks source link

Added configuration for Slow query log #94

Closed grapheo12 closed 3 years ago

grapheo12 commented 3 years ago

Followed this: https://gist.github.com/akirattii/40b284332e887f2f3dcdc4bca08517a5 Tested that the slow.log appears at /var/log/mysql/ inside the image.

grapheo12 commented 3 years ago

Please review @thealphadollar @icyflame .

thealphadollar commented 3 years ago

@icyflame @amrav Can you please find sometime to review this PR again, @grapheo12 has implemented the requested changes. Only once you give your nod, we will deploy this.

thealphadollar commented 3 years ago

@icyflame Thanks for your review :D

I came across #73. Do you think we should incorporate the same in this PR as it also concerns the configuration?

cc/ @grapheo12

amrav commented 3 years ago

LGTM :)

Please interpret approval + comments as good to merge after addressing comments (ie don't wait for reapproval from me). Also would suggest merging as-is and opening another PR if you want to make further changes, rather than keeping this PR open for more than a few days.

On Sun, Aug 23, 2020 at 3:35 PM Shivam Kumar Jha notifications@github.com wrote:

@icyflame https://github.com/icyflame Thanks for your review :D

I came across #73 https://github.com/metakgp/metakgp-wiki/issues/73. Do you think we should incorporate the same in this PR as it also concerns the configuration?

cc/ @grapheo12 https://github.com/grapheo12

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/metakgp/metakgp-wiki/pull/94#issuecomment-678781889, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJBT75NCTRCNTYTUN74A53SCESK3ANCNFSM4PZOM75Q .