add mathjs - Githubissues

metakirby5 / codi.vim

:notebook_with_decorative_cover: The interactive scratchpad for hackers.

MIT License

3k stars 83 forks source link

add mathjs #112

Closed slavaGanzin closed 4 years ago

slavaGanzin commented 4 years ago

Mathjs is kinda calculator with some neat features 2019-07-08-164028_955x239_scrot

Use case is smth like: https://soulver.app/

metakirby5 commented 4 years ago

Thanks for your contribution 😄 I pushed some whitespace fixes to your branch and left some comments to address.

metakirby5 commented 4 years ago

I noticed that the expression doesn't actually evaluate until we feed another newline to the buffer. Can you look into why that is?

Actually, it seems that the issue only persists until a second line is edited - if the second line is deleted, the first line will continue to evaluate until exit. There might be some other underlying issue, but it's low priority and shouldn't block this PR. Will merge once we resolve the comment about math -> mathjs.

slavaGanzin commented 4 years ago

@metakirby5 I, by error, rewrite your commits, but it seems it looks the same.

metakirby5 commented 4 years ago

Thanks for the changes! Final thing: can you add documentation to the following places?

README.md: Line after "Languages with built-in support:"
doc/codi.txt: Table in codi-interpreters-defaults
- For this one, perhaps with the note that evaluation may not work until a newline is entered.

slavaGanzin commented 4 years ago

@metakirby5 Ethan, anything else needed to merge this?

metakirby5 commented 4 years ago

@metakirby5 Ethan, anything else needed to merge this?

Yes - can you make the changes I requested above in README.md and doc/codi.txt?

slavaGanzin commented 4 years ago

Is it ok? https://github.com/metakirby5/codi.vim/pull/112/commits/fdb54c6023347111a1795762bf4b00257d50c606

metakirby5 commented 4 years ago

Oops, I guess I missed those changes for some reason. Looks good, thanks!