Check spelling and fix last remaining errors

[majst01]

IMPORTANT:

breaking because Assets.MachineType.StorageDescription was misspelled

@simcod can you please check where this property was used ? If only in the console, i think we can merge and release this.

From now on spell checking is done in CI

[simcod]

I found the misspelling here in the api-server as well:

https://github.com/metal-stack-cloud/api-server/blob/6bc66314dc688589e1358fb9a00ba1506edd6a02/pkg/service/asset/asset-service.go#L179

https://github.com/metal-stack-cloud/api-server/blob/6bc66314dc688589e1358fb9a00ba1506edd6a02/pkg/service/asset/asset-service.go#L195

In the console we are not using the storage description and within terraform, I will correct this as well.

[majst01]

I found the misspelling here in the api-server as well:

https://github.com/metal-stack-cloud/api-server/blob/6bc66314dc688589e1358fb9a00ba1506edd6a02/pkg/service/asset/asset-service.go#L179

https://github.com/metal-stack-cloud/api-server/blob/6bc66314dc688589e1358fb9a00ba1506edd6a02/pkg/service/asset/asset-service.go#L195

In the console we are not using the storage description and within terraform, I will correct this as well.

Sure, the api-server implements the api

[simcod]

I found the misspelling here in the api-server as well: https://github.com/metal-stack-cloud/api-server/blob/6bc66314dc688589e1358fb9a00ba1506edd6a02/pkg/service/asset/asset-service.go#L179 https://github.com/metal-stack-cloud/api-server/blob/6bc66314dc688589e1358fb9a00ba1506edd6a02/pkg/service/asset/asset-service.go#L195 In the console we are not using the storage description and within terraform, I will correct this as well.

Sure, the api-server implements the api

True, I rather wanted to point at the variables used there. They have the misspelling as well. The api related part naturally runs through there as well.