search

metal-stack / csi-driver-lvm

MIT License
121 stars 26 forks source link

add container images for arm and arm64 #41

Closed brlbil closed 3 years ago

brlbil commented 3 years ago

I have fixed the build issue on arm arch

In the make file I had to removedockerimage anddockerpush instead I put step dockerbuildpush because I could not find the same workflow for docker buildx build which is required for multi-arch container creation.

I also modified dockerimages workflow to accommodate docker builx

resolves issue

Gerrit91 commented 3 years ago

@mwennrich The pipeline currently does not support fork pull requests. You can set up the pipelines as we did for other projects, e.g.: https://github.com/metal-stack/gardener-extension-provider-metal/blob/master/.github/workflows/pull_request.yaml#L15-L17

brlbil commented 3 years ago

@mwennrich The pipeline currently does not support fork pull requests. You can set up the pipelines as we did for other projects, e.g.: https://github.com/metal-stack/gardener-extension-provider-metal/blob/master/.github/workflows/pull_request.yaml#L15-L17

I made the change and the pipeline is green now 👍