search

metal-stack / csi-driver-lvm

MIT License
121 stars 26 forks source link

tags on volumegroups #49

Closed majst01 closed 3 years ago

majst01 commented 3 years ago

it seems that tags can not be applied:

docker run -it --rm golang:1.15-alpine                                                                                                                                                                                               
/go # apk add lvm2                                                                                                                                                                                                                                                                        
fetch http://dl-cdn.alpinelinux.org/alpine/v3.12/main/x86_64/APKINDEX.tar.gz                                                                                                                                                                                                              
fetch http://dl-cdn.alpinelinux.org/alpine/v3.12/community/x86_64/APKINDEX.tar.gz
(1/6) Installing libaio (0.3.112-r1)
(2/6) Installing libblkid (2.35.2-r0)
(3/6) Installing device-mapper-libs (2.02.186-r1)
(4/6) Installing device-mapper-event-libs (2.02.186-r1)
(5/6) Installing lvm2-libs (2.02.186-r1)
(6/6) Installing lvm2 (2.02.186-r1)
Executing busybox-1.31.1-r19.trigger
OK: 12 MiB in 21 packages
/go # vgcreate -h
  vgcreate - Create a volume group

  vgcreate VG_new PV ...
        [ -A|--autobackup y|n ]
        [ -c|--clustered y|n ]
        [ -l|--maxlogicalvolumes Number ]
        [ -p|--maxphysicalvolumes Number ]
        [ -M|--metadatatype lvm2 ]
        [ -s|--physicalextentsize Size[m|UNIT] ]
        [ -f|--force ]
        [ -Z|--zero y|n ]
        [    --addtag Tag ]

But in https://github.com/metal-stack/csi-driver-lvm/blob/master/pkg/lvm/lvm.go#L481 there is --add-tag ?