search

metal-stack / csi-driver-lvm

MIT License
126 stars 26 forks source link

Bumps versions for k8s-sig images and fixes rbac #60

Closed dmarkwat closed 2 years ago

dmarkwat commented 3 years ago

Support for arm64 was missing due to the use of k8s-sigs images that predated being built cross-platform. The bump in images works on arm64, but only with the additional inclusion of the RBAC change.

This covers create and delete cases for PVCs following the mytest example. Not sure if resize will work; it's possible there's an rbac missing there, too. But if it's anything like the one for the attacher, it's just a missing .../status resource.

Might be worth parameterizing the various k8s-sig images? Happy to do it if anyone thinks that'd be useful.

romoh commented 2 years ago

Is the repo behind what's officially published? When adding the chart as dependency, I get the versions in this PR while the repo is way behind. 

- name: csi-driver-lvm
  version: "0.4.1"
  repository: "https://helm.metal-stack.io"

If so, can this be merged?

Gerrit91 commented 2 years ago

Sorry for slow response, your requested changes were already integrated into the chart, which is now located on https://github.com/metal-stack/helm-charts. It works at least with K8s v1.24 now. Thanks for your PR!