search

metal-stack / csi-driver-lvm

MIT License
120 stars 25 forks source link

Support other filesystem types #77

Closed jonasasx closed 1 year ago

jonasasx commented 1 year ago

Resolves https://github.com/metal-stack/csi-driver-lvm/issues/13 For example xfs added

majst01 commented 1 year ago

I added the @mwennrich as reviewer as well, lets wait for his approval

majst01 commented 1 year ago

first #78 must be merged, to make CI pass.

majst01 commented 1 year ago

Can you please add a bats (in tests/bats ) to test with xfs as well

Gerrit91 commented 1 year ago

I merged #78, CI tests are working again. Please rebase or pull master.

jonasasx commented 1 year ago

Due testing I found an Issue with old volumes signatures. If we create volume where another volume had been before, blkid returns xfs_external_log type. So I added force formatting in this case.

majst01 commented 1 year ago

You must silent this warning:

G204: Subprocess launched with a potential tainted input or cmd arguments (gosec)

jonasasx commented 1 year ago

@majst01 help with failed pipeline, please.

majst01 commented 1 year ago

@majst01 help with failed pipeline, please.

This is because you PRs from outside are not able to log in into our registry for push.

From my side this is fine now !

jonasasx commented 1 year ago

When this feature will be released?

Gerrit91 commented 1 year ago

We made a release now and container images are also published on ghcr. You can use this deployment chart as well if you want: https://github.com/metal-stack/helm-charts/releases/tag/v0.3.27

Thanks for your contribution!