Update deps, fix linter errors

[majst01]

Required to pass linting with newer version of linter

[Gerrit91]

Tests do not pass anymore. :/

The first inline volume is provisioned and working, but when deploying a PVC after that, we get:

...
create-pvc-e6e4dcbc-a864-46b1-bbb9-c2437ad001e4 csi-lvmplugin-create I0120 08:09:20.098482       1 lvm.go:530] lvcreate [-v -n pvc-e6e4dcbc-a864-46b1-bbb9-c2437ad001e4 -W y -L 10485760b --addtag lv.metal-stack.io/csi-lvm-driver csi-lvm]      
create-pvc-e6e4dcbc-a864-46b1-bbb9-c2437ad001e4 csi-lvmplugin-create F0120 08:09:20.378193       1 createlv.go:38] Error creating lv: unable to create lv: exit status 5 output:  Rounding up size to full physical extent 12.00 MiB              
create-pvc-e6e4dcbc-a864-46b1-bbb9-c2437ad001e4 csi-lvmplugin-create   Creating logical volume pvc-e6e4dcbc-a864-46b1-bbb9-c2437ad001e4                                                                                                           
create-pvc-e6e4dcbc-a864-46b1-bbb9-c2437ad001e4 csi-lvmplugin-create   Archiving volume group "csi-lvm" metadata (seqno 37).                                                                                                                      
create-pvc-e6e4dcbc-a864-46b1-bbb9-c2437ad001e4 csi-lvmplugin-create   Activating logical volume csi-lvm/pvc-e6e4dcbc-a864-46b1-bbb9-c2437ad001e4.                                                                                                
create-pvc-e6e4dcbc-a864-46b1-bbb9-c2437ad001e4 csi-lvmplugin-create   activation/volume_list configuration setting not defined: Checking only host tags for csi-lvm/pvc-e6e4dcbc-a864-46b1-bbb9-c2437ad001e4.                                    
create-pvc-e6e4dcbc-a864-46b1-bbb9-c2437ad001e4 csi-lvmplugin-create   Creating csi--lvm-pvc--e6e4dcbc--a864--46b1--bbb9--c2437ad001e4                                                                                                            
create-pvc-e6e4dcbc-a864-46b1-bbb9-c2437ad001e4 csi-lvmplugin-create   Loading table for csi--lvm-pvc--e6e4dcbc--a864--46b1--bbb9--c2437ad001e4 (253:5).                                                                                          
create-pvc-e6e4dcbc-a864-46b1-bbb9-c2437ad001e4 csi-lvmplugin-create   Resuming csi--lvm-pvc--e6e4dcbc--a864--46b1--bbb9--c2437ad001e4 (253:5).                                                                                                   
create-pvc-e6e4dcbc-a864-46b1-bbb9-c2437ad001e4 csi-lvmplugin-create   Wiping known signatures on logical volume csi-lvm/pvc-e6e4dcbc-a864-46b1-bbb9-c2437ad001e4.                                                                                
create-pvc-e6e4dcbc-a864-46b1-bbb9-c2437ad001e4 csi-lvmplugin-create   Found existing signature on /dev/csi-lvm/pvc-e6e4dcbc-a864-46b1-bbb9-c2437ad001e4 at offset 1080: LABEL="(null)" UUID="a10c9331-85df-43fc-b067-c21c6c04d52f" TYPE="ext4" US
AGE="filesystem"                                                                                                                                                                                                                                  
create-pvc-e6e4dcbc-a864-46b1-bbb9-c2437ad001e4 csi-lvmplugin-create WARNING: ext4 signature detected on /dev/csi-lvm/pvc-e6e4dcbc-a864-46b1-bbb9-c2437ad001e4 at offset 1080. Wipe it? [y/n]: [n]                                                
create-pvc-e6e4dcbc-a864-46b1-bbb9-c2437ad001e4 csi-lvmplugin-create   Aborted wiping of ext4.                                                                                                                                                    
create-pvc-e6e4dcbc-a864-46b1-bbb9-c2437ad001e4 csi-lvmplugin-create   1 existing signature left on the device.                                                                                                                                   
create-pvc-e6e4dcbc-a864-46b1-bbb9-c2437ad001e4 csi-lvmplugin-create   Failed to wipe signatures on logical volume csi-lvm/pvc-e6e4dcbc-a864-46b1-bbb9-c2437ad001e4.                                                                              
create-pvc-e6e4dcbc-a864-46b1-bbb9-c2437ad001e4 csi-lvmplugin-create   Aborting. Failed to wipe start of new LV.                                                                                                                                  
create-pvc-e6e4dcbc-a864-46b1-bbb9-c2437ad001e4 csi-lvmplugin-create   Removing csi--lvm-pvc--e6e4dcbc--a864--46b1--bbb9--c2437ad001e4 (253:5)                                                                                                    
create-pvc-e6e4dcbc-a864-46b1-bbb9-c2437ad001e4 csi-lvmplugin-create   Archiving volume group "csi-lvm" metadata (seqno 38).                                                                                                                      
create-pvc-e6e4dcbc-a864-46b1-bbb9-c2437ad001e4 csi-lvmplugin-create   Creating volume group backup "/etc/lvm/backup/csi-lvm" (seqno 39). 

[Gerrit91]

First problem I was able to resolve by adding the --yes option to the lvcreate command.

Now only the resize does not work anymore:

csi-driver-lvm-plugin-nbpgq csi-driver-lvm-plugin I0120 08:37:46.251042       1 lvm.go:561] lvextend [-L 20971520b -r csi-lvm/pvc-74699459-4960-4fa5-9009-77d5461dcf4d]
csi-driver-lvm-plugin-nbpgq csi-driver-lvm-plugin E0120 08:37:46.543981       1 server.go:114] GRPC error: unable to umount lv: exit status 5 output:  /sbin/fsadm: execvp failed: No such file or directory
csi-driver-lvm-plugin-nbpgq csi-driver-lvm-plugin   Filesystem check failed.

I noticed the following:

❯ docker run --rm -it alpine:3.17 sh -c "apk add lvm2-extra && fsadm"
fetch https://dl-cdn.alpinelinux.org/alpine/v3.17/main/x86_64/APKINDEX.tar.gz
fetch https://dl-cdn.alpinelinux.org/alpine/v3.17/community/x86_64/APKINDEX.tar.gz
(1/1) Installing lvm2-extra (2.03.17-r1)
Executing busybox-1.35.0-r29.trigger
OK: 7 MiB in 16 packages
sh: fsadm: not found
❯ docker run --rm -it alpine:3.16 sh -c "apk add lvm2-extra && fsadm"
fetch https://dl-cdn.alpinelinux.org/alpine/v3.16/main/x86_64/APKINDEX.tar.gz
fetch https://dl-cdn.alpinelinux.org/alpine/v3.16/community/x86_64/APKINDEX.tar.gz
(1/11) Installing ncurses-terminfo-base (6.3_p20220521-r0)
(2/11) Installing ncurses-libs (6.3_p20220521-r0)
Executing bash-5.1.16-r2.post-install
(5/11) Installing libacl (2.3.1-r0)
(6/11) Installing libattr (2.5.1-r1)
(7/11) Installing gmp (6.2.1-r2)
(8/11) Installing skalibs (2.11.2.0-r0)
(9/11) Installing utmps-libs (0.1.2.0-r0)
(10/11) Installing coreutils (9.1-r0)
(11/11) Installing lvm2-extra (2.02.187-r2)
Executing busybox-1.35.0-r13.trigger
OK: 10 MiB in 25 packages
fsadm: Could not run lvm binary "lvm".

[Gerrit91]

Tests are passing now.