Adoption to firewall-controller-manager API `firewall.metal-stack.io/v2`

metal-stack / firewall-controller

A kubernetes controller running on bare-metal firewalls, creating nftables rules, configures suricata, collects network metrics

MIT License

47 stars 4 forks source link

Closed majst01 closed 1 year ago

majst01 commented 1 year ago

Is fully dependent on the new firewall-controller-manager being in place, must be a next major release
Changes to new architecture: Seed and Shoot client
Integration test was removed, because it was quite complex and it does not do a lot --> we need to rethink the integration tests and create new, more complete ones in another pull request

Closes #104. Closes #10.

References #35.

Gerrit91 commented 1 year ago

Upload currently failing for some reason, seems to be a tracked issue already: https://github.com/google-github-actions/setup-gcloud/issues/571

majst01 commented 1 year ago

Code review fine from my perspective. Unsure how to test, though. Eventually wait for further feedback from @majst01

I cannot approve because i was the initial creator of the PR :-)