search

metal-stack / firewall-controller

A kubernetes controller running on bare-metal firewalls, creating nftables rules, configures suricata, collects network metrics
MIT License
47 stars 4 forks source link

Renaming clusterwide to clusterWide. #16

Closed Gerrit91 closed 4 years ago

Gerrit91 commented 4 years ago

Just a very small renaming from something that popped into my eye. I think, you only find the word either "cluster-wide" or "cluster wide" in the internet.

Also something to think about: Isn't a resource that's not namespaced automatically "cluster-wide"? Do we even need this prefix?

mwindower commented 4 years ago

Cilium uses CiliumClusterwideNetworkPolicy as name, see https://docs.cilium.io/en/stable/policy/language/#clusterwide-policies

I would leave that as is.

Namespacing is not a hard requirement but I thaught it would be good to keep all resources that consider the firewall in the firewall namespace.

Gerrit91 commented 4 years ago

No problem. When you did this on purpose, let's leave it as it is.