search

metal-stack / firewall-controller

A kubernetes controller running on bare-metal firewalls, creating nftables rules, configures suricata, collects network metrics
MIT License
47 stars 4 forks source link

embed static assets #2

Closed majst01 closed 4 years ago

majst01 commented 4 years ago

In order to make distribution easier, we could add the static assets like service files into the binary, there are different approaches in the wild, probably go itself will ship such:

https://github.com/golang/go/issues/35950

mwindower commented 4 years ago

I'd vote for https://github.com/rakyll/statik because it has no depenencies.

majst01 commented 4 years ago

CRDs are now included and processed with: https://github.com/metal-stack/firewall-controller/commit/e1b8a0c0d108f486fc52acbc8e92ce7eaa32d31b we should adopt this for templates as well

mwindower commented 4 years ago

done for nftables template with ebc84e3a9746702fbedc028ee965f6c1d069cd37