Update controller runtime

majst01 commented 3 years ago

This PR includes:

overall dependency updates
update to controller-runtime 0.8.x and simplifications
linter bugs fixed part 1
enable golangci-lint -p bugs in ci
actually a real Bug was detected, but not fixed yet:

controllers/firewall_controller.go:130:53: SA4023: this comparison is always true (staticcheck)
        if err = r.reconcileFirewallServices(ctx, f, log); err != nil {
                                                           ^
controllers/firewall_controller.go:245:30: SA4023(related information): (*github.com/metal-stack/firewall-controller/controllers.FirewallReconciler).reconcileFirewallServices never returns a nil interface value (staticcheck)
func (r *FirewallReconciler) reconcileFirewallServices(ctx context.Context, f firewallv1.Firewall, log logr.Logger) error {

TODO:

[ ] fix remaining bugs
[ ] test in a image

majst01 commented 3 years ago

@GrigoriyMikhalkin please consider looking at this

majst01 commented 2 years ago

duplicate of #115, once #115 is merged, this PR can be closed.

majst01 commented 2 years ago

is obsolet

metal-stack / firewall-controller

Update controller runtime #74