metal-stack / firewall-controller

A kubernetes controller running on bare-metal firewalls, creating nftables rules, configures suricata, collects network metrics
MIT License
47 stars 4 forks source link

Allow running firewall-controller from PRs #97

Closed Gerrit91 closed 3 years ago

Gerrit91 commented 3 years ago

Currently we rely on Github releases and assets / the semver version of a release such that we have no simple way of running the firewall-controller from a pull request.

Maybe there is some way to make this possible?

Gerrit91 commented 3 years ago

Here's a small idea that establishes some more similarities to our other artifacts:

Gerrit91 commented 3 years ago

We should remove the CRD deployment from the gardener-extension-provider-metal and just let the firewall-controller deploy the CRDs. This will likely cause a slowdown in cluster provisioning time since the controller has to wait until the firewall-controller was able to deploy the CRD definitions.

mwindower commented 3 years ago

CRD needs to be deployed in the gepm - otherwise it would remove it on reconcilation.

eberlep commented 3 years ago

Done