search

metal-stack / gardener-extension-provider-metal

Implementation of the gardener-extension-controller for metal-stack
MIT License
24 stars 11 forks source link

Hitting Github API rate limits #174

Closed Gerrit91 closed 3 years ago

Gerrit91 commented 3 years ago

Our controller can die because too often it consume the Github API for retrieving the firewall release asset:

...
panic: GET https://api.github.com/repos/metal-stack/firewall-controller/releases: 403 API rate limit exceeded for 185.153.67.16. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.) [rate reset in 1m32s] [recovered]
        panic: GET https://api.github.com/repos/metal-stack/firewall-controller/releases: 403 API rate limit exceeded for 185.153.67.16. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.) [rate reset in 1m32s]
...

It even dies with a panic which we should avoid under all circumstances.

Gerrit91 commented 3 years ago

This code relies on the firewall-controller code / updater. One possible fix is to cache release assets in order not to fetch them again all the time.