search

metal-stack / gardener-extension-provider-metal

Implementation of the gardener-extension-controller for metal-stack
MIT License
24 stars 11 forks source link

Make firewall-controller updatable from pull requests. #197

Closed Gerrit91 closed 3 years ago

Gerrit91 commented 3 years ago

Release Notes

firewall-controller versions now need to be added to the cloud profile.
GrigoriyMikhalkin commented 3 years ago

Now tests are failing in CI only because of outdated firewall-controller version(locally tested with correct branch).

GrigoriyMikhalkin commented 3 years ago

I removed firewall CRDs. Tried to track logic, where CNWPs or Firewall resources created. And it looks like they're always installed at reconcilation stage. If installation fails and returns error, at least by default, reconcilation should restart, after some delay, for same event. Not sure if it's a right way in this specific case.