metal-stack / gardener-extension-provider-metal

Implementation of the gardener-extension-controller for metal-stack
MIT License
24 stars 11 forks source link

firewall update fails #246

Closed mwennrich closed 2 years ago

mwennrich commented 2 years ago
{"level":"info","ts":"2022-03-31T06:16:24.652Z","logger":"infrastructure_controller","msg":"Ensuring finalizer","infrastructure":"shoot--pz9cjf--mwen-fel/mwen-fel","operation":"reconcile"}
{"level":"info","ts":"2022-03-31T06:16:24.693Z","logger":"infrastructure_controller","msg":"Reconciling the infrastructure","namespace":"shoot--pz9cjf--mwen-fel","name":"mwen-fel"}
{"level":"info","ts":"2022-03-31T06:16:24.823Z","logger":"infrastructure-actuator","msg":"firewall creation in progress","cluster-id":"0c2127f6-4bd2-46be-85f3-2b2b86d36e96","cluster":"mwen-fel","succeeded":false}
{"level":"info","ts":"2022-03-31T06:16:24.847Z","logger":"infrastructure_controller","msg":"Successfully reconciled infrastructure","namespace":"shoot--pz9cjf--mwen-fel","name":"mwen-fel"}

https://github.com/metal-stack/gardener-extension-provider-metal/blob/master/pkg/controller/infrastructure/actuator_reconcile.go#L230-L233

checks, if firewall.Succeeded is false but firewall has a machined and then sets firewallActionUpdateCreationProgress

And https://github.com/metal-stack/gardener-extension-provider-metal/blob/master/pkg/controller/infrastructure/actuator_reconcile.go#L177-L181 then only checks, if firewall has been successfully reconciled ... but nobody does the actual reconciliation?

Probably regression of https://github.com/metal-stack/gardener-extension-provider-metal/pull/217