search

metal-stack / gardener-extension-provider-metal

Implementation of the gardener-extension-controller for metal-stack
MIT License
24 stars 11 forks source link

Mark speaker, csi-lvm-reviver and node-init as node-critical component #285

Closed dergeberl closed 1 year ago

dergeberl commented 1 year ago

What this PR does / why we need it:

This PR adds the node.gardener.cloud/critical-component label to speaker, csi-lvm-reviver and node-init DaemonSet introduced in https://github.com/gardener/gardener/pull/7406

Which issue(s) this PR fixes: Part of https://github.com/gardener/gardener/issues/7117

Special notes for your reviewer: https://github.com/gardener/gardener/pull/7406 is merged

Gerrit91 commented 1 year ago

So glad to see a contribution here, thanks! Very much appreciated! 😊

Unfortunately, the latest Golang release broke the good old hack scripts from the old Gardener version we are still at... we will provide a fix for the pipeline which you can then merge from master.

Gerrit91 commented 1 year ago

@dergeberl A fix is now merged. At least the test action should succeed now when you rebase this branch.

timebertt commented 1 year ago

/unhold now that https://github.com/gardener/gardener/pull/7406 is merged

Gerrit91 commented 1 year ago

/ok-to-build