metal-stack / gardener-extension-provider-metal

Implementation of the gardener-extension-controller for metal-stack
MIT License
24 stars 11 forks source link

Override DNS and NTP on the worker from NetworkIsolation if given #356

Closed majst01 closed 7 months ago

majst01 commented 9 months ago

add this into webhook/controlplane/ensurer.go

Implement the EnsureAdditionalFiles Interface.

Related: https://github.com/fi-ts/proxy-services/issues/4

vknabel commented 9 months ago

During implementation a few questions came up:

  1. Do we want to support things like DNSSEC or DNSOverTLS?
  2. timesyncd does not support non-standard ports. How should we handle wrong port configs? a. fail generation of files completely b. generate everything, skip wrong port, only fail if no port is valid c. just use port 123 and log that the port was misconfigured (preferred) d. always use port 123 without logging
  3. Do we want to support FallbackNTP?
majst01 commented 9 months ago

During implementation a few questions came up:

  1. Do we want to support things like DNSSEC or DNSOverTLS? should be possible to define
  2. timesyncd does not support non-standard ports. How should we handle wrong port configs? a. fail generation of files completely b. generate everything, skip wrong port, only fail if no port is valid c. just use port 123 and log that the port was misconfigured (preferred) d. always use port 123 without logging

Then port must not be specified for DNS in my opinion, use the same struct for all 3 types (DNS, NTP and Registry) is probably not a good idea

  1. Do we want to support FallbackNTP?

dont think so, if 2 or more ntp servers are defined, this should be enough

mwennrich commented 9 months ago

Looking at other cloudprofiles, they do simply add only the addresses to the cloudprofile:

Gerrit91 commented 7 months ago

Can this be closed?