search

metal-stack / gardener-extension-provider-metal

Implementation of the gardener-extension-controller for metal-stack
MIT License
24 stars 11 forks source link

shoot.Spec.Networking.Type is now mandatory #417

Closed majst01 closed 2 weeks ago

majst01 commented 2 weeks ago

We should default to calico if not already set

iljarotar commented 2 weeks ago

Shouldn't this line already take care of that? https://github.com/metal-stack/gardener-extension-provider-metal/blob/master/pkg/admission/mutator/defaulter.go#L100

majst01 commented 2 weeks ago

no because it is not set in the config, e.g. nil

iljarotar commented 2 weeks ago

What config? The defaulter config uses calico as a fallback

func (c *config) networkType() string {
    return c.string("DEFAULTER_NETWORKTYPE", "calico")
}
majst01 commented 2 weeks ago

You are right, no idea why this did not work ?

majst01 commented 2 weeks ago

Closing because the webhook was not running properly which caused this error