search

metal-stack / helm-charts

Contains metal-stack Helm charts
MIT License
2 stars 10 forks source link

Allow overriding of k8s-sigs images through helm #46

Closed romoh closed 2 years ago

romoh commented 2 years ago

A port of https://github.com/metal-stack/csi-driver-lvm/pull/70

Similar to other csi(s), enable overriding k8s sig images through helm. This allow using other images and not being locked to k8s sig ones. The change set current default values in values.yaml, but allow passing an override for each during helm install.

Ideally, we should allow overriding the full image details (name and tag as well), but kept the current version lock to minimize the changes/

Tested by comparing the output of helm template before and after the change.

Signed-off-by: Roaa Sakr romoh@microsoft.com

romoh commented 2 years ago

Just noticed this was already included in #29

Gerrit91 commented 2 years ago

Thanks for your PR though! Hope everything works out now for you. Please tell when there are any more issues.