search

metal-stack / helm-charts

Contains metal-stack Helm charts
MIT License
2 stars 10 forks source link

Fix mount for node-driver-registrar #65

Closed timp87 closed 1 month ago

timp87 commented 1 year ago

Currently --kubelet-registration-path parameter of node-driver-registrar container from csi-driver-lvm-plugin daemonSet points to the directory which is not mounted. Found this out when tried to run all csi-driver-lvm containers with readOnlyRootFilesystem securityContext set to "true".

timp87 commented 1 year ago

I'm not sure I understand this correctly as those two sockets provided for node-driver-registrar are actually the same socket. So it may make sense to just change path for --kubelet-registration-path to the same /csi/csi.sock instead of mounting it again under different path.

timp87 commented 2 months ago

Hello Anything else required here?

Gerrit91 commented 1 month ago

Sorry, it took this long to get a reaction from our side. We discussed this in the team and honestly we do not fully understand how it works. I assume it's just fine to merge it, so I will before having you to wait for another year.