metal-stack / metal-roles

Ansible roles for deploying metal-stack
MIT License
2 stars 2 forks source link

fix(sonic): docker log size #290

Closed vknabel closed 3 weeks ago

vknabel commented 1 month ago

for #285 (cc @iljarotar )

robertvolkmann commented 1 month ago

Could you also remove this nasty default for metal-core? https://github.com/metal-stack/metal-roles/blob/master/partition/roles/metal-core/defaults/main/main.yaml#L2

Gerrit91 commented 1 month ago

Suggestion from @robertvolkmann was also to extend the systemd-docker-service role to include two new template variables for configuring --log-opt max-size and --log-opt max-file along with the existing --log-driver flag (maybe even set reasonable default in case log driver is json-file in order to prevent disks running full on the mgmt-servers for example).

The advantage would also be that we do not need to restart the Dockerd during the rollout.

What do you think?

vknabel commented 1 month ago

Applied your suggestions in https://github.com/metal-stack/ansible-common/pull/30 If systemd_docker_log_driver is not set, json-file will be the default. And in this case we limit the log files and size. So nothing to do here anymore.

vknabel commented 3 weeks ago

not required anymore