Open shibaPuppy opened 3 months ago
I'm generally in favour of this idea but I'd like a design proposal on it since it adds API. I'd rather not see API that simply exposes everything that Ironic collects as raw information.
/triage accepted I will close https://github.com/metal3-io/baremetal-operator/issues/1227 in favor of this issue, create a design proposal first please in the metal3-docs repo.
@dtantsur @Rozzii I think it is reasonable to add LLDP content to the existing hardwareData. do you think we need to add a new CR? i think we can only start once this is decided.
I am fine with putting the LLDP data to the hardwareData, what about you @dtantsur ?
It depends on how much you want to add, really. If it's just a couple of fields, I'm good with that.
User Story since ironic allows you to configure LLDP collection, you should similarly be able to enter LLDP values in bmh status. see your network topology, understand the physical connections between devices, and troubleshoot more efficiently.
Detailed Description since LLDP information is collected at the ironic inspection stage, I think it should be collected at the same timing as HardwareData.
Anything else you would like to add: https://github.com/metal3-io/baremetal-operator/issues/1227
If a new CR (ex. network discovery) is created, will a new controller be needed? when I looked at the code again recently, I thought that going similar to PR would be the easiest direction without any changes.
/kind feature