search

metal3-io / baremetal-operator

Bare metal host provisioning integration for Kubernetes
Apache License 2.0
567 stars 244 forks source link

Add LLDP collection in bmh #1731

Open shibaPuppy opened 3 months ago

shibaPuppy commented 3 months ago

User Story since ironic allows you to configure LLDP collection, you should similarly be able to enter LLDP values ​​in bmh status. see your network topology, understand the physical connections between devices, and troubleshoot more efficiently.

Detailed Description since LLDP information is collected at the ironic inspection stage, I think it should be collected at the same timing as HardwareData.

Anything else you would like to add: https://github.com/metal3-io/baremetal-operator/issues/1227

If a new CR (ex. network discovery) is created, will a new controller be needed? when I looked at the code again recently, I thought that going similar to PR would be the easiest direction without any changes.

/kind feature

dtantsur commented 3 months ago

I'm generally in favour of this idea but I'd like a design proposal on it since it adds API. I'd rather not see API that simply exposes everything that Ironic collects as raw information.

Rozzii commented 3 months ago

/triage accepted I will close https://github.com/metal3-io/baremetal-operator/issues/1227 in favor of this issue, create a design proposal first please in the metal3-docs repo.

shibaPuppy commented 3 months ago

@dtantsur @Rozzii I think it is reasonable to add LLDP content to the existing hardwareData. do you think we need to add a new CR? i think we can only start once this is decided.

Rozzii commented 2 months ago

I am fine with putting the LLDP data to the hardwareData, what about you @dtantsur ?

dtantsur commented 2 months ago

It depends on how much you want to add, really. If it's just a couple of fields, I'm good with that.