metal3-io / baremetal-operator

Bare metal host provisioning integration for Kubernetes
Apache License 2.0
570 stars 253 forks source link

🌱 [backport] workflow pipeline with unit tests #1773

Closed lentzi90 closed 4 months ago

lentzi90 commented 4 months ago

Manual backport of https://github.com/metal3-io/baremetal-operator/pull/1770

This adds a unit test workflow and restructures the github workflows so that we run golangci-lint and unit tests first. Only when they have succeded will the pipeline continue with e2e tests. The goal is to conserve resources and avoid running pointless jobs. The commit also removes unnecessary permissions and avoids running the jobs if the PR is a draft.

metal3-io-bot commented 4 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

lentzi90 commented 4 months ago

/hold We need https://github.com/metal3-io/baremetal-operator/pull/1771 first...

lentzi90 commented 4 months ago

/test metal3-bmo-e2e-test-pull

lentzi90 commented 4 months ago

/test metal3-bmo-e2e-test-pull

lentzi90 commented 4 months ago

/retest

lentzi90 commented 4 months ago

/test ?

metal3-io-bot commented 4 months ago

@lentzi90: The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/metal3-io/baremetal-operator/pull/1773#issuecomment-2151842528): >/test ? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
lentzi90 commented 4 months ago

/retest

metal3-io-bot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/baremetal-operator/blob/release-0.5/OWNERS)~~ [kashifest] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
metal3-io-bot commented 4 months ago

@Sunnatillo: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/metal3-io/baremetal-operator/pull/1773#pullrequestreview-2103277915): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
lentzi90 commented 4 months ago

/cc @Rozzii

mquhuy commented 4 months ago

/lgtm