metal3-io / baremetal-operator

Bare metal host provisioning integration for Kubernetes
Apache License 2.0
570 stars 253 forks source link

🌱 Fix Set image tag for release branches and tags #1776

Open 7h3-3mp7y-m4n opened 4 months ago

7h3-3mp7y-m4n commented 4 months ago

✨

What this PR does / why we need it: This PR solves image tags, by adding a verification check and also setting the tag automatically

**Which issue(s) this PR fixes Fixes #1722

metal3-io-bot commented 4 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign kashifest for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/metal3-io/baremetal-operator/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
metal3-io-bot commented 4 months ago

Hi @7h3-3mp7y-m4n. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
tuminoid commented 3 months ago

/ok-to-test

Thanks for the PR! Please set the PR type to :seedling in the title. I'll review this shortly after all basic tests pass.

7h3-3mp7y-m4n commented 2 months ago

Sorry for the delay, as I see markdownlint and shellcheck are the recheck ones, I will raise a PR soon with a fix.

7h3-3mp7y-m4n commented 2 months ago

/retest

7h3-3mp7y-m4n commented 4 days ago

@tuminoid can you tell me what I am missing here? cause I'm confused

tuminoid commented 4 days ago

Let's run a retest so we can have fresh logs, the old logs have expired already.

/retest

metal3-io-bot commented 4 days ago

@7h3-3mp7y-m4n: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
shellcheck a14295570133190d43a6c7a5e8e1234defde1ae2 link true /test shellcheck
markdownlint a14295570133190d43a6c7a5e8e1234defde1ae2 link true /test markdownlint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
tuminoid commented 4 days ago

@tuminoid can you tell me what I am missing here? cause I'm confused

Please check the details links of shellcheck and markdownlint for details what is failing.

For the markdownlink checker failure, I'm not sure what that is complaining about as it just says "action failed" with no logs, I'll look into that.

7h3-3mp7y-m4n commented 3 days ago

@tuminoid can you tell me what I am missing here? cause I'm confused

Please check the details links of shellcheck and markdownlint for details what is failing.

For the markdownlink checker failure, I'm not sure what that is complaining about as it just says "action failed" with no logs, I'll look into that.

Thanks @tuminoid I'll look into that