Open 7h3-3mp7y-m4n opened 4 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign kashifest for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Hi @7h3-3mp7y-m4n. Thanks for your PR.
I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
Thanks for the PR! Please set the PR type to :seedling
in the title. I'll review this shortly after all basic tests pass.
Sorry for the delay, as I see markdownlint
and shellcheck
are the recheck ones, I will raise a PR soon with a fix.
/retest
@tuminoid can you tell me what I am missing here? cause I'm confused
Let's run a retest so we can have fresh logs, the old logs have expired already.
/retest
@7h3-3mp7y-m4n: The following tests failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
shellcheck | a14295570133190d43a6c7a5e8e1234defde1ae2 | link | true | /test shellcheck |
markdownlint | a14295570133190d43a6c7a5e8e1234defde1ae2 | link | true | /test markdownlint |
Full PR test history. Your PR dashboard.
@tuminoid can you tell me what I am missing here? cause I'm confused
Please check the details links of shellcheck and markdownlint for details what is failing.
For the markdownlink checker failure, I'm not sure what that is complaining about as it just says "action failed" with no logs, I'll look into that.
@tuminoid can you tell me what I am missing here? cause I'm confused
Please check the details links of shellcheck and markdownlint for details what is failing.
For the markdownlink checker failure, I'm not sure what that is complaining about as it just says "action failed" with no logs, I'll look into that.
Thanks @tuminoid I'll look into that
✨
What this PR does / why we need it: This PR solves image tags, by adding a verification check and also setting the tag automatically
**Which issue(s) this PR fixes Fixes #1722