search

metal3-io / baremetal-operator

Bare metal host provisioning integration for Kubernetes
Apache License 2.0
570 stars 253 forks source link

🐛 fix htpasswd generation in run_local_ironic.sh #1780

Closed tuminoid closed 3 months ago

tuminoid commented 3 months ago

It tries to execute the htpasswd string instead of redirecting it to file, thanks to extra subshell "$( ... )". Removed.

https://jenkins.nordix.org/blue/organizations/jenkins/metal3-dev-env-integration-test-ubuntu-main/detail/metal3-dev-env-integration-test-ubuntu-main/21/pipeline/

[2024-06-11T06:57:16.454Z] /home/metal3ci/go/src/github.com/metal3-io/baremetal-operator/tools/run_local_ironic.sh: line 176: YC76iK4sKn42:$2y$05$DPXYNTSnqeIG9RGFEREgd.we9gOOlFbnsKQPnAPlF2lSzzCotRM6C: command not found
[2024-06-11T06:57:16.454Z] make: *** [Makefile:12: launch_mgmt_cluster] Error 127
tuminoid commented 3 months ago

/test ?

metal3-io-bot commented 3 months ago

@tuminoid: The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/metal3-io/baremetal-operator/pull/1780#issuecomment-2160040592): >/test ? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
tuminoid commented 3 months ago

/test metal3-dev-env-integration-test-ubuntu-main

tuminoid commented 3 months ago

We can see it passed the problematic stage: https://jenkins.nordix.org/blue/organizations/jenkins/metal3-dev-env-integration-test-ubuntu-main/detail/metal3-dev-env-integration-test-ubuntu-main/22/pipeline/

/cc @kashifest @Rozzii

Rozzii commented 3 months ago

/lgtm

MahnoorAsghar commented 3 months ago

Thanks for the fix, lgtm

kashifest commented 3 months ago

/approve

metal3-io-bot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/baremetal-operator/blob/main/OWNERS)~~ [kashifest] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment