metal3-io / baremetal-operator

Bare metal host provisioning integration for Kubernetes
Apache License 2.0
570 stars 253 forks source link

:bug: Fix incorrect htpasswd file generation #1786

Closed Rozzii closed 3 months ago

Rozzii commented 3 months ago

This commit:

The reason:

Fixes: #1785

Rozzii commented 3 months ago

/test ?

metal3-io-bot commented 3 months ago

@Rozzii: The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/metal3-io/baremetal-operator/pull/1786#issuecomment-2167801455): >/test ? > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Rozzii commented 3 months ago

/test metal3-centos-e2e-integration-test-main

Rozzii commented 3 months ago

/cc @kashifest

tuminoid commented 3 months ago

/cc @dtantsur

kashifest commented 3 months ago

/approve thanks for the fix and debugging @Rozzii @tuminoid

metal3-io-bot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/baremetal-operator/blob/main/OWNERS)~~ [kashifest] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment