search

metal3-io / baremetal-operator

Bare metal host provisioning integration for Kubernetes
Apache License 2.0
570 stars 253 forks source link

🐛 fix make install and make uninstall #1789

Closed matthewei closed 3 months ago

matthewei commented 3 months ago

🐛 fix make install and make uninstall

What this PR does / why we need it: fix make install and make uninstall

Which issue(s) this PR fixes: Fixes #1788

metal3-io-bot commented 3 months ago

Hi @matthewei. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
tuminoid commented 3 months ago

/ok-to-test

Put the emoji to the start of the title line to fix PR verifier failures.

matthewei commented 3 months ago

/ok-to-test

Put the emoji to the start of the title line to fix PR verifier failures.

done

matthewei commented 3 months ago

@dhellmann Do you have any comments?

elfosardo commented 3 months ago

/lgtm

dtantsur commented 3 months ago

/approve

Next time, please provide a more descriptive commit/PR message. "Fix something" is usually not enough: you need to at least specify what is broken (obvious here but won't be in even slightly more complex case).

metal3-io-bot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/baremetal-operator/blob/main/OWNERS)~~ [dtantsur] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
matthewei commented 3 months ago

/approve

Next time, please provide a more descriptive commit/PR message. "Fix something" is usually not enough: you need to at least specify what is broken (obvious here but won't be in even slightly more complex case).

got it