search

metal3-io / baremetal-operator

Bare metal host provisioning integration for Kubernetes
Apache License 2.0
570 stars 253 forks source link

:seedling: Always upload test artifacts, even if the tests fail #1791

Closed mquhuy closed 3 months ago

mquhuy commented 3 months ago

By default, if a step in github action fails, the subsequent steps won't be run. This is not ideal in case of running e2e tests, as we would like the tests artifacts to be uploaded, even if the tests fail.

This PR enables test artifacts upload for failed tests.

mquhuy commented 3 months ago

/cc @tuminoid @kashifest @Rozzii @adilGhaffarDev

Rozzii commented 3 months ago

/lgtm

metal3-io-bot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest, tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/baremetal-operator/blob/main/OWNERS)~~ [kashifest] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment