:seedling: Use basic-checks image in generate and gomod tests

metal3-io / baremetal-operator

Bare metal host provisioning integration for Kubernetes

Apache License 2.0

554 stars 241 forks source link

:seedling: Use basic-checks image in generate and gomod tests #1795

Closed mquhuy closed 2 weeks ago

mquhuy commented 3 weeks ago

As a continuation of https://github.com/metal3-io/project-infra/pull/797, we use basic-checks image in local tests too for BMO.

tuminoid commented 3 weeks ago

Also, let's merge this first https://github.com/metal3-io/baremetal-operator/pull/1796 so this can be tested locally. Changing the docker image here doesn't mean anything from CI perspective, so it needs a manual test.

tuminoid commented 3 weeks ago

/cc @kashifest

metal3-io-bot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/baremetal-operator/blob/main/OWNERS)~~ [dtantsur] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment