search

metal3-io / baremetal-operator

Bare metal host provisioning integration for Kubernetes
Apache License 2.0
570 stars 253 forks source link

:seedling: E2E: Remove gomega in LoadBMCConfig() #1806

Closed mquhuy closed 3 months ago

mquhuy commented 3 months ago

A minor PR to not use gomega's Expect() in LoadBMCConfig().

Reason: Using Expect() inside the function prevents reusage of the function in locations where ginkgo is not in use (e.g. https://github.com/metal3-io/baremetal-operator/pull/1767). This inclusion is unnecessary anyway, and Expect() should be located in the e2e suite.

mquhuy commented 3 months ago

/cc @tuminoid @Rozzii @mboukhalfa @Sunnatillo @adilGhaffarDev @huutomerkki

metal3-io-bot commented 3 months ago

@adilGhaffarDev: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/metal3-io/baremetal-operator/pull/1806#pullrequestreview-2158158521): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
metal3-io-bot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/baremetal-operator/blob/main/OWNERS)~~ [dtantsur] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment